Skip to content

Do not decref borrowed module dict reference #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ndgrigorian merged 2 commits into from
Aug 31, 2026
+2 −1
Merged

Do not decref borrowed module dict reference #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85100c9
Do not decref borrowed module dict reference
antonwolfy Aug 31, 2026
f59a8f2
Add changelog entry for module dict over-decref fix
antonwolfy Aug 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

### Fixed
* Fixed an over-decref of the borrowed module dictionary reference on the module initialization error path [gh-264](https://github.com/IntelPython/mkl_umath/pull/264)

## [0.5.0] - 2026-08-06

Expand Down
2 changes: 1 addition & 1 deletion mkl_umath/src/ufuncsmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ PyMODINIT_FUNC PyInit__ufuncs(void)
import_umath();

if (InitOperators(d) < 0) {
Py_XDECREF(d);
/* d is a borrowed reference from PyModule_GetDict; do not decref it. */
Py_XDECREF(m);
return NULL;
}
Expand Down
Loading