fix(lint): clear all 15 oxlint warnings - #620
Open
aniruddhaadak80 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clears all 15
oxlintwarnings (npm run lint: 15 warnings / 0 errors before, 0 / 0 after). No behavior change — dead stores, useless fallbacks, and unused bindings only:web/static/js/diffPanel.mjs:41,59,82— removes write-only#taskId(staleness is tracked by#requestId; the field was assigned inload/clearbut never read).web/static/js/sessionPanel.mjs:28,134— removes write-only#tab(#setTabassigned it but nothing reads it; the DOMactiveclass is the source of truth).web/static/js/threadBoard.mjs:17— drops the useless?? {}spread fallback (spreadingundefinedis already a no-op).web/static/js/themeBoot.js:16,web/static/js/webToken.js(7 sites: lines 46, 55, 80, 267, 347, 416, 441) — barecatchwhere the binding was never used.src/support/web.tailscale.test.ts:12-13— removes unusedreadFileSync/isTailscaleAddressimports (tests import the latter dynamically from./web.js).src/adapters/webTools.test.ts:160—?.['X-VEGA-Key']so the optional chain cannot throw wheninitis undefined.src/automation/dailyReporter.ts:26-33— removes uncalledreadWatermark(onlywriteWatermarkis ever invoked) and its now-unusedreadFileSyncimport.Related issue
No open issue exists (the repo currently has zero open issues). Proactive hygiene discovered by running the repo's own gate (
npm run lint) on a clean checkout — CI runs lint first, so warning-free output keeps the gate signal clean.Type of change
Checklist
npm run lintpasses (0 warnings, 0 errors; was 15/0)npm run typecheckpassesnpm run buildpasses — not run to completion locally (fulltscemit exceeds the local command timeout on this Windows checkout);typecheck(tsc --noEmit -p tsconfig.check.json) passes on the touched TS filesnpm testpasses for the touched areas (tests/web/diffPanel.test.ts: 13 passed;tests/web/threadBoard.test.ts: 5 passed;src/adapters/webTools.test.ts: 23 passed;tests/web/sessionSelection.test.ts+tests/web/format.test.ts: 11 passed). Note:src/support/web.tailscale.test.ts(touched only by removing two provably-unused imports) cannot complete locally — it times out identically on cleanmain(importing./web.jshangs on this Windows checkout), so this is pre-existing and unrelated