Skip to content

fix: off-main-thread null check in ReleaseMemoryTexture/ReleaseMemorySprite #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
niclas-bolle wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: off-main-thread null check in ReleaseMemoryTexture/ReleaseMemorySprite #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Unity-Package/Assets/root/Runtime/Future/Types/FutureSprite.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ public static void ReleaseMemorySprite(Sprite sprite, DebugLevel logLevel = Debu
}

// 'sprite.texture' could be called only from main thread
// checking sprite.IsNull is enough until we are in main thread
if (sprite.IsNull())
// Unity's == (used by IsNull) throws off the main thread, e.g. from a Reference finalizer
if (ReferenceEquals(sprite, null))
return;

UniTask.Post(() =>
Expand Down
3 changes: 2 additions & 1 deletion Unity-Package/Assets/root/Runtime/Future/Types/FutureTexture.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ public static void ReleaseMemoryTexture(Texture2D obj, DebugLevel logLevel = Deb
UnityEngine.Object.DestroyImmediate(obj);
return;
}
if (obj.IsNull())
// Unity's == (used by IsNull) throws off the main thread, e.g. from a Reference finalizer
if (ReferenceEquals(obj, null))
return;

UniTask.Post(() =>
Expand Down