Describe the bug
pcapkit/all.py maintains __all__ by hand, and the list has gone stale. These names are exported by their packages but missing from pcapkit.all.__all__, so from pcapkit.all import * leaves them out:
- From
pcapkit.protocols: ESP, HTTPv1, HTTPv2, IPv6_Ext and PCAPNG.
- From
pcapkit.corekit: EnumRegistry, info_final, MultiDict, OrderedMultiDict and ModuleDescriptor.
- From
pcapkit.foundation: ReassemblyManager, TraceFlowManager and six register_* callbacks.
git log -S finds no commit that ever added them to all.py. No comment explains their absence, and tests/project/test_public_api.py does not cover pcapkit.all.
Expected behavior
Every public name from the aggregated packages is exported, or its omission is recorded as deliberate, with a test that keeps the list in step.
Blocked until
#1129 merges, because it edits pcapkit/all.py.
Additional context
The #1129 cross-review found this.
Describe the bug
pcapkit/all.pymaintains__all__by hand, and the list has gone stale. These names are exported by their packages but missing frompcapkit.all.__all__, sofrom pcapkit.all import *leaves them out:pcapkit.protocols:ESP,HTTPv1,HTTPv2,IPv6_ExtandPCAPNG.pcapkit.corekit:EnumRegistry,info_final,MultiDict,OrderedMultiDictandModuleDescriptor.pcapkit.foundation:ReassemblyManager,TraceFlowManagerand sixregister_*callbacks.git log -Sfinds no commit that ever added them toall.py. No comment explains their absence, andtests/project/test_public_api.pydoes not coverpcapkit.all.Expected behavior
Every public name from the aggregated packages is exported, or its omission is recorded as deliberate, with a test that keeps the list in step.
Blocked until
#1129 merges, because it edits
pcapkit/all.py.Additional context
The #1129 cross-review found this.