Skip to content

fix(all): pcapkit.all.__all__ omits names its packages export #1136

Description

@JarryShaw

Describe the bug
pcapkit/all.py maintains __all__ by hand, and the list has gone stale. These names are exported by their packages but missing from pcapkit.all.__all__, so from pcapkit.all import * leaves them out:

  • From pcapkit.protocols: ESP, HTTPv1, HTTPv2, IPv6_Ext and PCAPNG.
  • From pcapkit.corekit: EnumRegistry, info_final, MultiDict, OrderedMultiDict and ModuleDescriptor.
  • From pcapkit.foundation: ReassemblyManager, TraceFlowManager and six register_* callbacks.

git log -S finds no commit that ever added them to all.py. No comment explains their absence, and tests/project/test_public_api.py does not cover pcapkit.all.

Expected behavior
Every public name from the aggregated packages is exported, or its omission is recorded as deliberate, with a test that keeps the list in step.

Blocked until
#1129 merges, because it edits pcapkit/all.py.

Additional context
The #1129 cross-review found this.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    fixPull requests that fix a defect (fix: subject prefix)

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions