Skip to content

ci: two cron comments say "everyday" for a Saturday-only schedule #964

Description

@JarryShaw

Two scheduled workflows describe their own cron as daily when it is weekly:

.github/workflows/cron-vendor.yml:5:    - cron: '0 10 * * 6' # everyday at 10am
.github/workflows/cron-conda.yml:8:    - cron: '0 10 * * 6' # everyday at 10am

0 10 * * 6 is minute 0, hour 10, day-of-week 6 — Saturdays at 10:00 UTC
(no workflow sets a timezone: override, and scheduled workflows default to
UTC). The schedules themselves are correct and intended; only the comments are
wrong.

The repo's own prose already has it right, which is what makes the comments
misleading rather than merely terse: docs/source/contributing/workflows.rst:108
labels the node schedule (Saturday), releasing.rst:32 calls the vendor crawl
weekly, and tests/_dependency_gates.py:457 says "the three Saturday schedules".

Of the four other scheduled workflows, three carry no cron comment at all —
codeql-analysis.yml:10, deploy-pages.yml:16, python-compatibility.yml:9.
The fourth, lint.yml:138-139, already carries a correct one naming Saturday
and the sibling schedules. So the defect is confined to the two files above.

Surfaced by the cross-review on #963, which found the cron-vendor.yml instance;
the cron-conda.yml copy turned up on checking whether it was the only one.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ciPull requests that change CI or workflow configuration (ci: subject prefix)docsPull requests that change documentation only (docs: subject prefix)

    Projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions