Repository navigation
docs(contributing): tighten the prose from the post-sweep merges (#719) - #1075
Conversation
|
Coverage: 86.48% (unit tier, Python 3.14,
Per-file detail: the |
|
Cross-review verdict on The reviewer found no required changes:
The reviewer also noted that the ruleset prose still describes a 22-context ruleset. I checked the live ruleset 23497679 myself: it requires 6 contexts, |
- Cut issue/PR numbers, dates and "used to" history from the comments the queue-cut, coverage and project-status changes added to unit-tests.yml, project-status.yml, coverage-comment.yml, pyproject.toml and util/run_unittest_leg.py, keeping each rationale. - Correct statements the per-class re-import made stale: coverage.toml's "thousands of tests purge in setUp" and pyproject's "a generation per test" for the retained pytest-timeout timer. - State the ruleset's current six required contexts in unit-tests.yml and workflows.rst, with why the aggregate and the separate Compat legs exist. - Fix counts: coverage.toml and test_coverage_rcfile.py name three added keys (parallel, patch, core), not two; test_unit_tests_queue.py's docstring lists five pins, not "three". - Fix unit-tests.yml's stale pyproject.toml:151 marker reference (157) and renumber the unit-tests.yml citations in workflows.rst and releasing.rst. Comments, docstrings and prose only: AST / parsed-YAML / parsed-TOML equal to origin/main for every touched file; tests/project passes; Sphinx -n shows no new warnings.
42fd0b2 to
f73b188
Compare
|
Cross-review verdict on This round covers the ruleset-prose rewrite from
|
make pylint,make mypy,make isort) — not run; comments/docstrings only, AST-equal belowmake testpasses, and a test case covers the change —tests/project(375 passed, 1 skipped) plus each touched module aloneWhat is the purpose of your pull request?
docs— documentation onlyDescription of your pull request and other information
Final #719 pass over the prose the post-#1056 merges added to
docs/source/contributing/,tests/project/,util/,.github/andpyproject.toml.pyproject.tomlandutil/run_unittest_leg.pycomments; rationales kept (tests/citations left alone, being exempt).coverage.toml's "thousands of tests purge in setUp";pyproject.toml's "a generation per test").Required checks passed+Compat Python 3.10-3.14) inunit-tests.ymlandworkflows.rst, keeping why the aggregate and the separateCompatlegs exist.parallel,patch,core), not two;test_unit_tests_queue.pylists five pins, not "three".unit-tests.yml's stalepyproject.toml:151(the marker is at 157) and renumbers theunit-tests.yml:Ncitations inworkflows.rst/releasing.rst(pinned byTestDocCitationsResolve).Numstat: 10 files, +130 / -152.
Sphinx
-ninto fresh dirs, branch vsorigin/main: 1293 vs 1293 warnings, none new.origin/main.github/coverage.toml.github/workflows/coverage-comment.yml.github/workflows/project-status.yml.github/workflows/unit-tests.ymlpyproject.tomltests/project/test_coverage_rcfile.pytests/project/test_unit_tests_queue.pyutil/run_unittest_leg.py