Repository navigation
ci(cron): say Saturday where the cron is Saturday-only (#964) - #965
Conversation
Both scheduled crawlers annotated `0 10 * * 6` as "everyday at 10am". The day-of-week field is 6, so the schedule is Saturdays at 10:00 UTC, in both `cron-vendor.yml` and `cron-conda.yml`. Comment text only. `yaml.safe_load` on each file before and after returns equal structures, so no trigger, job or step is altered.
|
GOOD TO GO at I claimed the four other scheduled workflows "carry no comment at all". Re-derived independently on my side: One fact worth recording rather than acting on: |
make pylint,make mypy,make isort)make testpasses, and a test case covers the change — N/A, comment text only, no behaviour to coverWhat is the purpose of your pull request?
ci— workflows or build toolingDescription of your pull request and other information
Closes #964.
Both scheduled crawlers annotated
0 10 * * 6as "everyday at 10am". Theday-of-week field is
6, so it fires Saturdays at 10:00 UTC — the schedule isright, the comment was not. Fixed in
cron-vendor.yml:5andcron-conda.yml:8.The repo's prose already had it right, which is what made the comments
misleading rather than merely terse:
docs/source/contributing/workflows.rst:108labels that node
schedule (Saturday),releasing.rst:32calls the crawlweekly, and
tests/_dependency_gates.py:457says "the three Saturday schedules".Of the four other scheduled workflows, three carry no cron comment —
codeql-analysis.yml:10,deploy-pages.yml:16,python-compatibility.yml:9.The fourth,
lint.yml:138-139, already carries a correct one. So nothing elserepeats the defect.
Comment text only.
yaml.safe_loadon each file before and after returnsequal structures (
STRUCTURES EQUAL: Truefor both), so no trigger, job or stepchanges. Found by the cross-review on #963; the
cron-conda.ymlcopy turned upon checking whether
cron-vendor.ymlwas the only one.