Repository navigation
Conversation
|
Test status for this pull request: SUCCESS Summary: summary.txt Build log: make_nsj_fdc_smear.log |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The readout of the FDC cathodes produces pulse height, not integrated charge, so I modified the hit merging correspondingly, in a manner similar to that done for the CDC.
If there are both random and simulated hits on the same strip, the earlier hit is kept and the later one ignored.
If two hits arrive in the same time sample, q is summed.
The plots below show real data from run 70370 and simulated data with the old mcsmear and then the new mcsmear.
There is negligible difference between the two. However it can be seen that the simulated threshold is too high, as the first time peak is from the randoms. I'll look into fixing that next.
The new merging gives results only slightly differrent from the new merging because (for the run tested)
93% of new hits contained a random but no real hit on the same strip
4% of new hits were where a random hit arrived before a real hit and so replaced it
3% of new hits the real hit arrived first and was preserved
0.1% of new hits the real and random arrived in the same sample and q was summed.
Even though the new merging makes only a little difference to the output, I would like to use it because the method is correct.
Below, the new version is shown in red and the old in black. The only difference that I can see is that the two peaks in the time histogram are slightly higher in the new version (red).

Same histograms, log scale or zoomed in:
