fix(claude): scope allowlisted commands and drop the auto-format hook - #11
Merged
Merged
Conversation
|
Warning Review limit reachedNext included review available in 58 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying umi-react-admin with
|
| Latest commit: |
7f687cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://bf03c721.umi-react-admin.pages.dev |
| Branch Preview URL: | https://fix-claude-config.umi-react-admin.pages.dev |
- replace the Bash(pnpm *) wildcard (any script/exec/dlx execution) and npm run * with an enumerated list of low-risk commands; pnpm run/exec/ dlx and everything else now go through the normal approval prompt - remove the PostToolUse hook that ran 'pnpm format' after every Write/Edit: it executed a package.json script with zero interaction, so a tampered script in a merged PR meant arbitrary code execution on every contributor's machine (lint-staged already covers formatting) - widen the env-file deny to **/.env* so nested env files are covered, and deny 'cat .env*' explicitly - keep the CESIUM_ION_TOKEN env passthrough: local builds need it and the allowlist above no longer offers a prompt-free exfil path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
审计 2026-09-22 H-2（09-20 已提出、一直未修）：入库的
.claude/settings.json对所有在此仓库使用 Claude Code 的人生效，三项叠加构成零交互供应链执行面：Bash(pnpm *)全量放行——pnpm 是任意脚本执行器（run <任意 script>/exec/dlx）PostToolUse钩子在每次 Write/Edit 后无条件执行pnpm format——即 package.json 的 script，可被恶意 PR 毫不起眼地篡改，维护者打开仓库即触发任意代码执行env.CESIUM_ION_TOKEN直通注入 + Bash 放行使deny Read(.env*)可经pnpm exec node -e零提示绕过改动
pnpm run/exec/dlx与一切未列出命令回归正常的逐次审批Read(**/.env*)（覆盖子目录）并显式加Bash(cat .env*)env.CESIUM_ION_TOKEN（本地构建需要），allowlist 收敛后它不再有免提示外发通道验证