chore(deps): upgrade phase 3 — FullCalendar 7, Tailwind CSS 4 - #18
Merged
Merged
Conversation
FullCalendar 6 -> 7 - daygrid/timegrid/interaction/multimonth packages are gone; plugins come from @fullcalendar/react/* entrypoints, temporal-polyfill is a new peer, @fullcalendar/core is no longer a direct dependency - v7 ships no CSS: skeleton + Classic theme (the v6 look) + palette - types renamed (DateSelectArg -> DateSelectInfo, EventClickArg -> EventClickInfo, EventContentArg -> EventDisplayInfo) - the palette switches on an ancestor [data-color-scheme], now driven by the app theme, so the calendar follows dark mode - visible deltas: day numbers were blue in v6 only because antd colors bare <a>; column headers are no longer bold (v7 default) Tailwind CSS 3 -> 4 (umi 4.7 compiles it via @tailwindcss/webpack) - tailwind.config.js replaced by CSS-first config in tailwind.css: theme + utilities imports without preflight, @theme inline for the antd CSS-variable bridge (inline is required: the --ant-* vars live on .css-var-* scopes, not :root), @source limited to src ts/tsx, @source not inline() instead of blocklist - utilities are imported unlayered on purpose: layered utilities lose every conflict against antd CSS-in-JS, antd reset.css, CSS modules and third-party sheets; unlayered keeps v3 cascade semantics - the calendar sidebar's space-y-3 becomes the equivalent v3 selector (v4 space-y is a :where() margin-bottom that antd typography margins override) - stylelint knows the v4 at-rules; README states the new browser baseline (Chrome 111 / Firefox 128 / Safari 16.4) - .eslintignore un-ignores the root dotfile configs: lint-staged passed .stylelintrc.js explicitly, ESLint 8 warned "File ignored by default" and --max-warnings=0 blocked any commit touching it verified: 17 pages pixel-identical to phase 2 except the calendar (1440x900, dev build side by side); calendar select-create, click- delete, view tabs, weekends toggle; 24 routes clean console; size gate and both builds pass
|
Warning Review limit reachedNext included review available in 43 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (10)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying umi-react-admin with
|
| Latest commit: |
773d961
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f838a3d6.umi-react-admin.pages.dev |
| Branch Preview URL: | https://chore-deps-phase3.umi-react-admin.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
背景
依赖升级 阶段 3:FullCalendar 7 与 Tailwind CSS 4。以阶段 2(
chore/deps-phase2)为 base。改动
FullCalendar 6 → 7
@fullcalendar/react/*入口导入;新增 peer 依赖temporal-polyfillDateSelectArg→DateSelectInfo、EventClickArg→EventClickInfo、EventContentArg→EventDisplayInfodata-color-scheme<a>链接色染蓝的role=tabTailwind CSS 3 → 4(umi 4.7 经
@tailwindcss/webpack编译)tailwind.config.js,配置迁入tailwind.css:@theme inline。必须用 inline:--ant-*变量挂在.css-var-*作用域上,不在:root@source把扫描范围限定在 src 下的 ts/tsx@source not inline()取代原来的 blocklist@layer:分层后的工具类在与 antd CSS-in-JS、antd reset、CSS Modules 和第三方样式冲突时一律落败。不分层可以保持 v3 的层叠语义,理由也写在tailwind.css头部注释里space-y-3改为与 v3 等价的选择器。v4 的 space-y 改成了零特异性的 margin-bottom,会输给 antd 排版组件自带的外边距.eslintignore取消忽略根目录的两个点文件配置。原先任何改动.stylelintrc.js的提交都会被 pre-commit 挡住(ESLint 8 报「File ignored by default」,在 --max-warnings=0 下失败)验证
pnpm check、体积门禁、两条构建均通过(体积与阶段 2 基本相同)var(--ant-*)、被拦截的类名没有生成、--color-gray-200已输出需要注意
Tailwind 4 依赖
@property/color-mix(),全站浏览器基线提高到 Chrome 111+ / Firefox 128+ / Safari 16.4+。