「式の構築」の分割・並び換え - #161
Draft
konn wants to merge 31 commits into
Draft
Conversation
NY57
self-requested a review
June 11, 2026 12:41
NY57
reviewed
Jun 15, 2026
Member
There was a problem hiding this comment.
正直、全然レビュー出来ていませんがいくつかコメントをつけました。
あと、全体を通してやると良さそうかなと思う内容(対応必須ではない)について以下に記載します。
- ナップサック問題を題材とする説明があるが、ページ分割により逆にわかりにくくなってしまっている(不要になっている)印象を受ける。ナップサック問題を題材とせず、その説明に適したシンプルなコードに出来れば変えたい。
- 複数のコードセルに渡るものをなるべく減らしたい。折角ページ分割や見出しで検索性を上げたので、見つけたコードセルをそのまま動かせる形にするほうがドキュメントとしての体験が良いように思う。
Co-authored-by: OpenAI Codex <codex@openai.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
Co-authored-by: Codex <codex@openai.com>
Co-authored-by: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked by #166 .
TODOs
日本語版
英語版