Repository navigation
Conversation
add forgotten file add forgotten file
tweak testing add forgotten test file
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
ablaom
marked this pull request as draft
October 18, 2026 20:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a major breaking update implementing the proposal at #64.
It additionally closes: #47, #62 and replaces #66, #68, #70, #71.
Detailed document strings have been added to all public methods and New Documenter.jl documentation replaces the README.md docs. The demos in
/examplesare now integrated into the new documentation.Draft release notes below tag breaking changes. The main change is to the output of
train!which will be a vector of newControlTraceobjects, which, by default, record a complete history of the internal state of each control with intuitive API. Here's a demonstration:Requirements
Draft release notes
(enhancement - breaking) The form of the return value of
IterationControl.train!(model, ...)has changed. Now a vector ofControlTraceobjects is returned. By default, each trace records a complete history of (an public
form) of the control's internal state. For example, the trace of any callback control
records a history of the values returned by the calling function.
(new default - breaking)
Step()is now the same asStep(1)(new default - breaking)
Callback()is now the same asCallback(identity)(new default - breaking)
WithNumberDo()is now the same asWithNumberDo(identity)(new default - breaking)
WithLossDo()is now the same asWithLossDo(identity)(new default - breaking)
WithTraininLossesDo()is now the same asWithTrainingLossesDo(identity)(API change - breaking for custom controls) (for new implementations)
takedown(control, verbosity, state)should now only return a short (possible empty)message string, which it should log to
:infoif it's non-empty andverbosity > 0. Ideally the message should fit on one line. (Detailed information can be accessedwith
EarlyStopping.public_state(control, state).) A new control traitneeds_ingest(model)should be implemented for custom controls that requireIterationControl.ingest!(model, datum)to be implemented to supportmodel.(logging changes) What
train!logs toInfo(apart from control-specific logging)has changed; logging is less verbose by default.
Support for julia < 1.10 is dropped.