Repository navigation
Conversation
peter-evans/create-pull-request rebases only the changes made during the workflow onto `base` whenever `base` differs from the checked-out ref, so the spawned PR contained the generated markdown but none of the parent PR's own commits. Build the branch directly instead: for a pull_request event the checkout is the merge commit, so branching from HEAD and committing the generated files gives a branch that diffs against the base as "parent's changes + generated files". Create/update the PR with gh. Also add an explicit permissions block, now that the job pushes directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
|
Attention A notebook or Project.toml file has changed and new notebook markdown has been generated. Review #103, which replaces the current PR, to commit the changes and update the documentation on gh-pages. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR — do not merge.
Exercises the reworked
generate_notebooks.yml, which no longer usespeter-evans/create-pull-request. That action rebases only the changes madeduring the workflow onto
base, which dropped the parent PR's own commitsfrom the spawned PR.
What to check on the spawned "Commit Notebook Markdown Changes" PR:
notebook.jledit), not just the regenerated markdownnotebook.mdon topIncludes a deliberate DUMMY commit to
UsingMLJ/01_basics/notebook.jlpurelyto trigger regeneration.