test(e2e): pick datasets with an uploaded version, not v0 leftovers - #56
Merged
Conversation
pfitzseb
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55.
Since #54, the e2e dataset tests pick the first dataset of the right type from
jh dataset list— butfirstIDOfTypenever looks at theVersion:line. On nightly-juliahub the first Blob in the UUID-ordered listing is a 0-byteVersion: v0leftover (created by an integration test's CORS check that never uploads), soTestDatasetStatusFirst/TestDatasetDownloadFirsttrip the CLI's own "no versions available for dataset" fail-fast — red every nightly since #54 merged (08-20, 08-21, 08-24).Changes:
firstIDOfTypenow also requiresVersion: v[1-9][0-9]*within the entry block, so only datasets with at least one uploaded version drive the happy-path tests. Applies to all four*First/*FirstBlobTreetests (a v0 BlobTree would misfire the same way).TestFirstIDOfType(credential-less parse pin) extended: aVersion: v0entry and an entry with noVersion:line must both be skipped.Verified:
go test -tags e2e -run TestFirstIDOfType ./e2epasses; gofmt clean.