Repository navigation
Fix CI for #73 - #74
Merged
Merged
Conversation
ZGroup has no metadata field in ZarrCore 0.11.1, so zarr_format(ds)
raised a FieldError and every add_var call failed. The format is the
group's zarr_format field, a ZarrFormat{N} that converts to Int.
Co-authored-by: Claude 🤖 <noreply@anthropic.com>
ZarrCore.zcreate takes the format as the zarr_format keyword. The tests that call it directly passed format, which zcreate rejects; format is the keyword of the YAXArrayBase functions only. Co-authored-by: Claude 🤖 <noreply@anthropic.com>
The Zarr v3 zarr.json files carry the format version under the key zarr_format; there is no key named format. Co-authored-by: Claude 🤖 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the test failures on this branch: ZGroup has no
metadatafield (usezarr_format), the tests passedformatwherezcreatetakeszarr_format,and one read the wrong v3 key. 122 pass, 1 error ("Reading Zarr": expired
certificate at s3.bgc-jena.mpg.de; same on master).
Co-authored-by: Claude 🤖 noreply@anthropic.com