Avoid extra philox calls with ElementRNG - #723
Conversation
|
There are many interesting bugs with using |
|
Due to JuliaLang/julia#62507 I'm restricting Float16 tests to Julia versions 1.13 or later. |
That's excessive. Float16 had been working fine before; why does it only fail here? If it's specific to a test, you can always add a specific version-gated filter on top of the |
|
The Julia 1.12 miscompile only happens on CPUs with avx512_fp16. Github actions will sometimes use a CPU with avx512_fp16 now. If you run the existing tests enough times you can see the failure. I've limited the removal of Float16 tests to only Julia 1.12 and avx512_fp16 CPUs. |
ef81f59 to
f94690c
Compare
|
The Float16 issue should be solved on 1.12.7, so I removed the workaround. Also rebased the PR. |
|
Thanks. The AMDGPU i128 problem will hopefully be fixed by either llvm/llvm-project#213523 or llvm/llvm-project#214518 |
In the interim, let's do JuliaGPU/AMDGPU.jl#1066 |
Fixes #721
This PR avoids some extra philox calls when using
ElementRNG.ElementRNGis used as anAbstractRNGwhen sampling any non batched type including types with custom samplers defined in different packages.This PR also makes
ComplexF16a batched type.