Repository navigation
Fix doctest for widen - #357
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 7 7
Lines 792 792
=======================================
Hits 770 770
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kimikage
force-pushed
the
fix_widen_doctest
branch
from
October 14, 2026 11:52
da00732 to
92b56dc
Compare
kimikage
marked this pull request as ready for review
October 14, 2026 11:52
Collaborator
Author
|
We will review the issue found in the nightly build before v0.9.3 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My stance is that doctest is a tool for finding errors in documentation, and there is no need to run it on anything other than the latest release (or LTS).
IIRC, in a discussion somewhere other than this package, I received a counterargument along the lines of "It’s a good thing that doctest passes."