Repository navigation
Add JET workflow - #358
Add JET workflow#358kimikage wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #358 +/- ##
=======================================
Coverage 97.22% 97.22%
=======================================
Files 7 7
Lines 792 792
=======================================
Hits 770 770
Misses 22 22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f6fc589 to
b7d746b
Compare
PatrickHaecker
left a comment
There was a problem hiding this comment.
I recommend to implement the two suggested changes. The PR otherwise looks good to me.
| run: julia --project=. --color=yes -e ' | ||
| using JET, Test; | ||
| using FixedPointNumbers; | ||
| println("report_package(FixedPointNumbers, toplevel_logger=nothing)"); | ||
| show(JET.report_package(FixedPointNumbers, toplevel_logger=nothing)); | ||
| @testset "JET" begin | ||
| JET.test_package(FixedPointNumbers; target_modules=(FixedPointNumbers,)); | ||
| end' |
There was a problem hiding this comment.
| run: julia --project=. --color=yes -e ' | |
| using JET, Test; | |
| using FixedPointNumbers; | |
| println("report_package(FixedPointNumbers, toplevel_logger=nothing)"); | |
| show(JET.report_package(FixedPointNumbers, toplevel_logger=nothing)); | |
| @testset "JET" begin | |
| JET.test_package(FixedPointNumbers; target_modules=(FixedPointNumbers,)); | |
| end' | |
| run: | | |
| julia --project=. --color=yes -e ' | |
| using JET, Test, FixedPointNumbers | |
| @testset "JET" begin | |
| JET.test_package(FixedPointNumbers; target_modules=(FixedPointNumbers,)) | |
| end' |
report_package analyzes the package a second time. Without target_modules, it also lists reports from other modules, and those do not affect the result. When test_package fails, it already prints the reports that caused the failure.
The | block, keeps the newlines, so no trailing semicolons are needed improving readability.
There was a problem hiding this comment.
I thought it might be helpful to include potential issues as reference information.
If you feel it's annoying, I'll remove it.
b7d746b to
eba3c4d
Compare
eba3c4d to
ca203be
Compare
This is the workflow (GitHub Actions) version of PR #324.
CC: @PatrickHaecker