Fix isone for sparse matrices with stored zeros - #764
Merged
Conversation
`isone(A::AbstractSparseMatrixCSC)` only validated the stored entries it encountered and relied on `nnz(A) >= n` as a proxy for "every column has a diagonal entry". A matrix with a stored zero and a missing diagonal entry therefore passed, e.g. `sparse([1 0; 1 1]) * sparse([1 0; -1 0])`. Track per column whether a stored diagonal entry equal to one was seen, and return `false` otherwise. Fixes #763 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XzN6CtuVBJWDVc88ShNYso
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 83.99% 84.01% +0.02%
==========================================
Files 13 13
Lines 9366 9378 +12
==========================================
+ Hits 7867 7879 +12
Misses 1499 1499 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isone(A::AbstractSparseMatrixCSC)only validated the stored entries it encountered and usednnz(A) >= nas a proxy for "every column has a diagonal entry". A matrix with a stored zero and a missing diagonal entry therefore passed:This PR tracks, per column, whether a stored diagonal entry equal to one was seen, and returns
falseotherwise. Added regression tests covering the issue's example, stored zeros on and off the diagonal, and a missing diagonal entry.Fixes #763
🤖 Generated with Claude Code
https://claude.ai/code/session_01XzN6CtuVBJWDVc88ShNYso