Add findnz for adjoint/transpose of sparse matrices and vectors - #765
Merged
Conversation
`findnz(A')` threw a `MethodError` for sparse `A`. Add methods for `Adjoint`/`Transpose` wrappers of `AbstractSparseMatrixCSC` (via the linear-time materialized transpose, so indices come out in column-major order of the wrapper) and of sparse vectors (returning `(I, J, V)` with the values adjointed/transposed as appropriate). Fixes #632 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XzN6CtuVBJWDVc88ShNYso
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #765 +/- ##
==========================================
+ Coverage 83.99% 84.15% +0.16%
==========================================
Files 13 13
Lines 9366 9386 +20
==========================================
+ Hits 7867 7899 +32
+ Misses 1499 1487 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
findnz(A')threw aMethodErrorfor a sparse matrixA.This PR adds:
findnz(::AdjOrTrans{<:Any,<:AbstractSparseMatrixCSC}), implemented via the linear-time materialized transpose so that(I, J, V)come out in column-major order of the wrapper, matchingfindnz(SparseMatrixCSC(A')).findnz(::AdjOrTrans{<:Any,<:SparseVectorUnion}), returning(I, J, V)for the 1×n wrapper with values adjointed/transposed as appropriate.Test.detect_ambiguities(SparseArrays)remains empty.Fixes #632
🤖 Generated with Claude Code
https://claude.ai/code/session_01XzN6CtuVBJWDVc88ShNYso