Temp Fix for Contact Page - #502
Conversation
CGBassPlayer
added
third-party site
design
gerbrent
left a comment
gerbrent
left a comment
There was a problem hiding this comment.
tested, looks good as expected.
|
proof from Firefox' responsive mode set to iPhone X - though I can't reproduce the issue on current production JB site w this method......:
|
The original issue was reported by a user of a "pixel7pro" felt important to point this out as not webkit-only... and curious if the fix might influence that context aswell - likely! |
|
It does and it doesn't. The test expansion handles multiple browsers, but I haven't worked in emulation yet. But the WebKit browser failed the test without this change. So while it will it fixes all the browser at a large scale. I can't say for certain it fixes the mobile simply because I don't have a way to test yet. |
|
.... you do now! https://jb-deploy-prv-iac8.onrender.com/ (from deployment previews) generated automagically on PR merge) |
|
So on my iPhoneX it seems like it wasn't quite enough... I am not too worried about it since I want to get a native contact form working on the site soon. |
|
Want to give it another 5-10px while we're at it? |
|
I was thinking at least 20px. Since this PR is merged, I am pretty sure I would need to open a new one |
|
other way is a revert (I can do that) and change, then remerge? That would have a slightly cleaner history.. I believe. |
|
That actually could work since I don't think there was anything merged after this one. We can certainly give it a shot |
|
...Here we go! |
|
note that... revert doesn't necessarily help w clean history - it's subjective at this point ; ) |
|
@CGBassPlayer I'll let you do the new PR w above tiny changes - probably overkill to revert at this point but... today we learn. |
2 participants
Fixes #485
On Safari/Webkit browsers, the iframe was too small and cut off the bottom button when all validation errors are present. This increases the size of the iframe by 5 pixels as a band-aid until we remake the contact form.
e2e testing for that browser is part of #475