ci: add support for aarch64-apple-darwin in build matrix - #458
Open
Roberto-deP-Martins wants to merge 1 commit into
Open
Roberto-deP-Martins wants to merge 1 commit into
Roberto-deP-Martins wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #135
The binary compiled for aarch64-apple-darwin successfully in https://github.com/Roberto-deP-Martins/parallel-disk-usage/actions/runs/34907432730/job/104187247347. The tests also went fine https://github.com/Roberto-deP-Martins/parallel-disk-usage/actions/runs/34907432730/job/104187247483.
I also compiled it locally and tested it in a project that used a previous version of PDU compiled for x86. No behaviour changes were observed.
This change would prevent MacOS apps that use a PDU binary from triggering an OS notification warning that the app will no longer be compatible in the future, as well as ensuring compatibility once Apple drops support for running x86 apps via Rosetta.