Conversation
…edit due to stale cache (#2329) * KC-1408: Treat first-time share invitations as success in Service Mode (#2325) * KC-1408: Treat first-time share invitations as success in Service Mode (#2303) * Treat first-time share invitations as success in Service Mode * Use ShareInviteSentError so NSF invite success does not mask real share failures * Fix test imports for deleted pam_debug modules Remove imports and tests for PAMDebugACLCommand and PAMDebugLinkCommand, which were deleted in commit 2f1447a. Update test file to only include tests for modules that still exist. * added PathDelimiter (#2328) * KC-1427: Add NSF folder support to list-sf --roe-eligible (#2323) * Support NSF folders in list-sf --roe-eligible Add search_nested_share_folders() helper and extend RecordListSfCommand to include NSF folders with PAM User rotation in --roe-eligible results. Enables integrations (Slack, Google Chat) to detect PAM eligibility on NSF folders. * Add NSF folder support to list-sf --roe-eligible with folder_type column Gate NSF search behind --roe-eligible flag; add folder_type column ('Classic' or 'Nested') to enable integrations to distinguish classic vs NSF folder UIDs. Includes test coverage. * NSF: failed to load record for ls * Fix NSF record fields reverting after pam tunnel/connection edit due to stale cache * Fix NSF record fields reverting after pam tunnel edit Load fresh record from raw cache after sync to avoid stale objects. * Fix NSF record fields reverting after pam tunnel/connection edit. Reload fresh record from cache after sync to avoid stale TypedRecord instances. * addressed review comments * Fix unit test mocks: update_pam_record should return False, remove redundant decorator --------- Co-authored-by: pvagare-ks <pvagare@keepersecurity.com> Co-authored-by: Sergey Kolupaev <skolupaev@keepersecurity.com>
craiglurey
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSF record fields were reverting to stale values after
pam tunnel edit,pam connection edit, orpam rbi editwhen run immediately afternsf-record-update. The initialsync_down_preserving_nsf_keys()refreshed the server cache, but in-memory TypedRecord instances remained stale with old field values. When these commands calledupdate_pam_record(), they read from the stale objects and wrote old values back to the server, overwriting the updates.Changes
keepercommander/commands/pam/vault_target.py: Modifiedreload_pam_record_if_nsf_updated()to raiseCommandErrorif reload fails after NSF update, preventing field reversion via stale datakeepercommander/commands/tunnel_and_connections.py: Removed alltry/exceptblocks wrappingsync_down_preserving_nsf_keys()calls; removed defensivehasattrchecks that allowed silent degradationkeepercommander/commands/pam_import/record_loader.py: Restored classic-cache-first priority order inload_pam_record()(classic cache → NSF cache fallback)keepercommander/nested_share_folder/record_api.py: Removed unnecessaryjson.loads(json.dumps())round-trip, store raw data directlyunit-tests/pam/test_pam_rbi_edit.py: Added@mock_sync_decoratorto test classes to properly mock sync and load operationsunit-tests/pam/test_pam_connection_edit_security.py&unit-tests/pam/test_pam_connection_edit_scrollback.py: Added@mock_sync_decoratorto test classes; addedreturn_value=Falsetoupdate_pam_recordmocks in EarlyReturn tests