DO NOT MERGE: DR-1368 add hashicorp pam config - #2337
Draft
mfordkeeper wants to merge 12 commits into
Draft
Conversation
#2325) * KC-1408: Treat first-time share invitations as success in Service Mode (#2303) * Treat first-time share invitations as success in Service Mode * Use ShareInviteSentError so NSF invite success does not mask real share failures * Fix test imports for deleted pam_debug modules Remove imports and tests for PAMDebugACLCommand and PAMDebugLinkCommand, which were deleted in commit 2f1447a. Update test file to only include tests for modules that still exist.
* Support NSF folders in list-sf --roe-eligible
Add search_nested_share_folders() helper and extend RecordListSfCommand to
include NSF folders with PAM User rotation in --roe-eligible results. Enables
integrations (Slack, Google Chat) to detect PAM eligibility on NSF folders.
* Add NSF folder support to list-sf --roe-eligible with folder_type column
Gate NSF search behind --roe-eligible flag; add folder_type column ('Classic'
or 'Nested') to enable integrations to distinguish classic vs NSF folder UIDs.
Includes test coverage.
…edit due to stale cache (#2329) * KC-1408: Treat first-time share invitations as success in Service Mode (#2325) * KC-1408: Treat first-time share invitations as success in Service Mode (#2303) * Treat first-time share invitations as success in Service Mode * Use ShareInviteSentError so NSF invite success does not mask real share failures * Fix test imports for deleted pam_debug modules Remove imports and tests for PAMDebugACLCommand and PAMDebugLinkCommand, which were deleted in commit 2f1447a. Update test file to only include tests for modules that still exist. * added PathDelimiter (#2328) * KC-1427: Add NSF folder support to list-sf --roe-eligible (#2323) * Support NSF folders in list-sf --roe-eligible Add search_nested_share_folders() helper and extend RecordListSfCommand to include NSF folders with PAM User rotation in --roe-eligible results. Enables integrations (Slack, Google Chat) to detect PAM eligibility on NSF folders. * Add NSF folder support to list-sf --roe-eligible with folder_type column Gate NSF search behind --roe-eligible flag; add folder_type column ('Classic' or 'Nested') to enable integrations to distinguish classic vs NSF folder UIDs. Includes test coverage. * NSF: failed to load record for ls * Fix NSF record fields reverting after pam tunnel/connection edit due to stale cache * Fix NSF record fields reverting after pam tunnel edit Load fresh record from raw cache after sync to avoid stale objects. * Fix NSF record fields reverting after pam tunnel/connection edit. Reload fresh record from cache after sync to avoid stale TypedRecord instances. * addressed review comments * Fix unit test mocks: update_pam_record should return False, remove redundant decorator --------- Co-authored-by: pvagare-ks <pvagare@keepersecurity.com> Co-authored-by: Sergey Kolupaev <skolupaev@keepersecurity.com>
* Fix Service Mode Host I/O * Handle alias for file import/export * Fix python3.9 test case * Fix token check for flags * Fix review comments * Remove extra comments and doc strings * Fix directory clean up race condition
mfordkeeper
requested review from
jwalstra-keeper,
m-afanasiuk,
maksimu,
miroberts and
sk-keeper
August 31, 2026 23:48
mfordkeeper
marked this pull request as draft
August 31, 2026 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an early review to add support for new HashiCorp PAM config record type via pam config new/edit. Also added support to kick off the sync via pam universal-sync-run but this is untested until corresponding support is actually added to the gateway.
Design doc here: https://docs.google.com/document/d/1oL3H83zp8wxJq3VUzhvo4DDJtXcm2DvbuChCxq2WZJg/edit?usp=sharing