Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions apps/web/src/app/(app)/components/AppTopbar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
BreadcrumbList,
BreadcrumbPage,
} from '@/components/ui/breadcrumb';
import { SystemMessageBanner } from '@/components/shared/SystemMessageBanner';

export function AppTopbar() {
const { title, icon, extras, hideTopbar } = usePageTitle();
Expand All @@ -30,6 +31,7 @@ export function AppTopbar() {
</BreadcrumbItem>
</BreadcrumbList>
</Breadcrumb>
<SystemMessageBanner />
{extras && <div className="shrink-0">{extras}</div>}
</div>
)}
Expand Down
18 changes: 18 additions & 0 deletions apps/web/src/components/shared/SystemMessageBanner.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { Megaphone } from 'lucide-react';

const SYSTEM_MESSAGE_TEXT = 'Important security notice';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUGGESTION: Hardcoded message requires a redeploy to change or remove

Because SYSTEM_MESSAGE_TEXT and SYSTEM_MESSAGE_URL are compile-time constants, updating the message (or taking it down once the notice is no longer relevant) requires a code change and a full redeploy. For a system/announcement banner — typically used for time-sensitive comms — consider sourcing these from an env var (e.g. NEXT_PUBLIC_SYSTEM_MESSAGE_TEXT / ..._URL) and rendering nothing when unset, so the banner can be changed or removed via config. Fine to keep hardcoded if this is intentionally a one-off notice.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is as per design for now.

const SYSTEM_MESSAGE_URL = 'https://blog.kilo.ai/';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING: Link text promises a specific notice but the URL is the blog root

The visible label is "Important security notice", which sets the expectation of a specific advisory, but SYSTEM_MESSAGE_URL points at https://blog.kilo.ai/ (the blog homepage). Users clicking it land on a generic listing page with no obvious security notice. If this is a placeholder, please point it at the actual post URL before merging.


Reply with @kilocode-bot fix it to have Kilo Code address this issue.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Text and URL pending. this was just a pre PR to push the branch in case someone needs to take over the branch.


export function SystemMessageBanner() {
return (
<a
href={SYSTEM_MESSAGE_URL}
target="_blank"
rel="noopener noreferrer"
className="flex min-w-0 shrink-0 items-center gap-1.5 rounded-md bg-primary px-3 py-1 text-xs font-medium text-primary-foreground hover:bg-primary/90"
>
<Megaphone aria-hidden="true" className="size-3.5 shrink-0" />
<span className="truncate underline-offset-2 hover:underline">{SYSTEM_MESSAGE_TEXT}</span>
</a>
);
}
Loading