Skip to content

2.6.0: Update Traits from PHP SDK #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
n7studios wants to merge 15 commits into
base: main
Choose a base branch
from
Open

2.6.0: Update Traits from PHP SDK #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
c9a42b7
Update Traits from PHP SDK
n7studios Jul 28, 2026
e63a62b
PHPStan compat.
n7studios Jul 28, 2026
bc69f73
Resources: Reorder method args
n7studios Jul 28, 2026
bd0ff16
Match SDK version number
n7studios Aug 10, 2026
c113b97
Use TestsTrait from PHP SDK
n7studios Aug 11, 2026
dc9358c
Add ObjectResponseProxy Helper
n7studios Aug 11, 2026
3c090c0
Add new .env vars
n7studios Aug 11, 2026
909c24f
Update .env
n7studios Aug 11, 2026
7af38e4
Reinstate get_posts_* tests that are WordPress specific
n7studios Aug 11, 2026
4dd02f1
Coding standards
n7studios Aug 11, 2026
54555ba
Remove dupliate CONVERTKIT_API_POST_ID from .env
n7studios Aug 11, 2026
3c48fcf
Override `testGetPost` to use WordPress Libraries version
n7studios Aug 11, 2026
406a408
Add `get_resource` method to match PHP SDK
n7studios Aug 11, 2026
2f5dd4c
get_html(): Treat 4xx and 5xx errors as a WP_Error
n7studios Aug 11, 2026
d8a3bd8
Reinstate PHP versions for tests
n7studios Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .env.dist.testing
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ TEST_SITE_HTTP_USER_AGENT_MOBILE=HeadlessChromeMobile
CONVERTKIT_API_BROADCAST_ID="8697158"
CONVERTKIT_API_CUSTOM_FIELD_ID="258240"
CONVERTKIT_API_FORM_ID="2765139"
CONVERTKIT_API_FORM_ID_2="2780977"
CONVERTKIT_API_LEGACY_FORM_ID="470099"
CONVERTKIT_API_LEGACY_FORM_URL="https://app.convertkit.com/landing_pages/470099"
CONVERTKIT_API_LANDING_PAGE_ID="2765196"
CONVERTKIT_API_LANDING_PAGE_URL="https://cheerful-architect-3237.kit.com/99f1db6843"
CONVERTKIT_API_LANDING_PAGE_CHARACTER_ENCODING_ID="2849151"
Expand All @@ -45,10 +47,13 @@ CONVERTKIT_API_LEGACY_LANDING_PAGE_URL="https://app.kit.com/landing_pages/470103
CONVERTKIT_API_POST_ID="3175837"
CONVERTKIT_API_PRODUCT_ID="36377"
CONVERTKIT_API_SEQUENCE_ID="1030824"
CONVERTKIT_API_SEQUENCE_EMAIL_ID="4533458"
CONVERTKIT_API_TAG_NAME="wordpress"
CONVERTKIT_API_TAG_ID="2744672"
CONVERTKIT_API_TAG_NAME_2="gravityforms-tag-1"
CONVERTKIT_API_TAG_ID_2="2907192"
CONVERTKIT_API_SUBSCRIBER_EMAIL="optin@n7studios.com"
CONVERTKIT_API_SUBSCRIBER_ID="1579118532"
CONVERTKIT_API_EMAIL_TEMPLATE_ID="5215567"
CONVERTKIT_API_SNIPPET_ID="136038"
CONVERTKIT_API_RECOMMENDATIONS_JS="https://cheerful-architect-3237.kit.com/WnaDZ370gtgOq750dwOl-recommendations.js"
5 changes: 5 additions & 0 deletions .env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ CONVERTKIT_OAUTH_REDIRECT_URI=
CONVERTKIT_API_BROADCAST_ID="8697158"
CONVERTKIT_API_CUSTOM_FIELD_ID="258240"
CONVERTKIT_API_FORM_ID="2765139"
CONVERTKIT_API_FORM_ID_2="2780977"
CONVERTKIT_API_LEGACY_FORM_ID="470099"
CONVERTKIT_API_LEGACY_FORM_URL="https://app.convertkit.com/landing_pages/470099"
CONVERTKIT_API_LANDING_PAGE_ID="2765196"
CONVERTKIT_API_LANDING_PAGE_URL="https://cheerful-architect-3237.kit.com/99f1db6843"
CONVERTKIT_API_LANDING_PAGE_CHARACTER_ENCODING_ID="2849151"
Expand All @@ -53,12 +55,15 @@ CONVERTKIT_API_LEGACY_LANDING_PAGE_URL="https://app.kit.com/landing_pages/470103
CONVERTKIT_API_POST_ID="3175837"
CONVERTKIT_API_PRODUCT_ID="36377"
CONVERTKIT_API_SEQUENCE_ID="1030824"
CONVERTKIT_API_SEQUENCE_EMAIL_ID="4533458"
CONVERTKIT_API_TAG_NAME="wordpress"
CONVERTKIT_API_TAG_ID="2744672"
CONVERTKIT_API_TAG_NAME_2="gravityforms-tag-1"
CONVERTKIT_API_TAG_ID_2="2907192"
CONVERTKIT_API_SUBSCRIBER_EMAIL="optin@n7studios.com"
CONVERTKIT_API_SUBSCRIBER_ID="1579118532"
CONVERTKIT_API_EMAIL_TEMPLATE_ID="5215567"
CONVERTKIT_API_SNIPPET_ID="136038"
CONVERTKIT_API_SIGNED_SUBSCRIBER_ID=
CONVERTKIT_API_SUBSCRIBER_TOKEN=
CONVERTKIT_API_RECOMMENDATIONS_JS="https://cheerful-architect-3237.kit.com/WnaDZ370gtgOq750dwOl-recommendations.js"
10 changes: 10 additions & 0 deletions phpcs.tests.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,13 @@
<!-- Inspect files in the /tests folder -->
<file>tests</file>

<!-- Exclude TestsTrait.php: it is a verbatim copy of the PHP SDK's
TestsTrait.php (PSR-12 style, snake_case handled by API contract).
Running WordPress coding standards on it produces hundreds of
false positives and would force the file to diverge from its SDK
master copy, defeating the copy-paste workflow. -->
<exclude-pattern>tests/Integration/TestsTrait.php</exclude-pattern>

<!-- Run in verbose mode and specify the precise rule that failed in output -->
<arg value="sv"/>
<arg name="colors"/>
Expand Down Expand Up @@ -37,6 +44,9 @@
<!-- Permit [] instead of array() -->
<exclude name="Universal.Arrays.DisallowShortArraySyntax.Found" />

<!-- Permit $fn instead of $function -->
<exclude name="Universal.NamingConventions.NoReservedKeywordParameterNames.fnFound" />

<!-- We might use some datetime functions for tests -->
<exclude name="WordPress.DateTime.RestrictedFunctions" />

Expand Down
Loading