Skip to content

Remove dead code from ProcessSubmission #3938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josephsnyder merged 1 commit into from
Aug 17, 2026
+0 −18
Merged

Remove dead code from ProcessSubmission #3938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions app/Jobs/ProcessSubmission.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,7 @@ class ProcessSubmission implements ShouldQueue
use Queueable;
use SerializesModels;

public int $timeout;

public $filename;
public string $localFilename = '';
public $projectid;
public $buildid;
public $expected_md5;
Expand All @@ -61,8 +58,6 @@ class ProcessSubmission implements ShouldQueue
*/
public function __construct($filename, $projectid, $buildid, $expected_md5)
{
$this->timeout = config('cdash.queue_timeout');

$context = [];
if (isset($projectid)) {
$context['projectid'] = $projectid;
Expand Down
1 change: 0 additions & 1 deletion config/cdash.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
'login_field' => env('LOGIN_FIELD', 'Email'),
'max_upload_quota' => env('MAX_UPLOAD_QUOTA', 10),
'notify_pull_request' => env('NOTIFY_PULL_REQUEST', false),
'queue_timeout' => env('QUEUE_TIMEOUT', 2000),
'retry_base' => env('QUEUE_RETRY_BASE', 5),
'show_last_submission' => env('SHOW_LAST_SUBMISSION', true),
'slow_page_time' => env('SLOW_PAGE_TIME', 10),
Expand Down
12 changes: 0 additions & 12 deletions phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4791,12 +4791,6 @@ parameters:
count: 1
path: app/Jobs/ProcessSubmission.php

-
rawMessage: 'Method App\Jobs\ProcessSubmission::__construct() throws checked exception TypeError but it''s missing from the PHPDoc @throws tag.'
identifier: missingType.checkedException
count: 1
path: app/Jobs/ProcessSubmission.php

-
rawMessage: 'Method App\Jobs\ProcessSubmission::check_email_update_errors() return type has no value type specified in iterable type array.'
identifier: missingType.iterableValue
Expand Down Expand Up @@ -4935,12 +4929,6 @@ parameters:
count: 1
path: app/Jobs/ProcessSubmission.php

-
rawMessage: 'Property App\Jobs\ProcessSubmission::$timeout (int) does not accept bool|int|string.'
identifier: assign.propertyType
count: 1
path: app/Jobs/ProcessSubmission.php

-
rawMessage: 'Parameter #1 $value of method Carbon\Carbon::subHours() expects float|int, bool|int|string given.'
identifier: argument.type
Expand Down