Reuse the Logger instead of reopening the log file on every call when saving to a file - #345
Open
connorshea wants to merge 1 commit into
Open
Reuse the Logger instead of reopening the log file on every call when saving to a file#345connorshea wants to merge 1 commit into
connorshea wants to merge 1 commit into
Conversation
When KNAPSACK_PRO_LOG_DIR was set, `KnapsackPro.logger` built a new `Logger` and reopened the log file on *every* call, because the log_dir branch ran unconditionally instead of only when no logger existed yet. A CI node leaked a Logger object and a file handle per log call. The stdout logger was already memoized; the log_dir logger now is too. Note one consequence worth a second opinion: assigning a custom logger (`KnapsackPro.logger = Rails.logger`) while KNAPSACK_PRO_LOG_DIR is set used to be silently overridden on the next `logger` call, and now wins. That looks like the intended behaviour of a public writer, but it is a change for anyone relying on the old precedence. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Member
|
Hey @connorshea, thanks for the PR! Quick question to help us prioritize the work: Is this creating problems in your projects and requires a quick release? |
Contributor
Author
No, if any of these PRs take a bit to merge and ship that's fine by me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
AI Disclosure: This was generated using Claude Code with Opus 5. It has been reviewed and tested by me.
When
KNAPSACK_PRO_LOG_DIRwas set,KnapsackPro.loggerbuilt a newLoggerand reopened the log file on every call. This fixes that behavior to reduce repetitive work and avoid the extra system calls that weren't necessary.Checks
UNRELEASEDsection of theCHANGELOG.md, including the needed bump (i.e., patch, minor, major)lib/knapsack_pro/pure/queue/rspec_pure.rbcontains pure functions that are unit tested.lib/knapsack_pro/extensions/rspec_extension.rbencapsulates calls to RSpec internals and is integration and E2E tested.lib/knapsack_pro/runners/queue/rspec_runner.rbinvokes the pure code and the extension to produce side effects, which are integration and E2E tested.