Repository navigation
Chore/absorb ai deck converter breaking change - #2293
harshadixit12 wants to merge 6 commits into
Conversation
d273eea to
6afd47a
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2293 +/- ##
==========================================
+ Coverage 36.69% 39.37% +2.67%
==========================================
Files 82 82
Lines 7943 7324 -619
==========================================
- Hits 2915 2884 -31
+ Misses 4761 4440 -321
+ Partials 267 0 -267 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
|
||
| // aiGatewayMinRuntimeVersion is the newest AI Gateway release the converter | ||
| // knows, so conversion keeps emitting the newest output shape. | ||
| const aiGatewayMinRuntimeVersion = "2.3" |
There was a problem hiding this comment.
I don't think we should be hardcoding versions here, let me see what can be done.
60a4ea4 to
ff8caae
Compare
| github.com/ettle/strcase v0.2.0 | ||
| github.com/fatih/color v1.19.0 | ||
| github.com/google/go-cmp v0.7.0 | ||
| github.com/gosimple/slug v1.15.0 |
There was a problem hiding this comment.
Not new - just being rearranged in the same file
|
|
||
| // aiGatewayMinRuntimeVersion is the newest AI Gateway release the converter | ||
| // knows, so conversion keeps emitting the newest output shape. | ||
| const aiGatewayMinRuntimeVersion = "2.2" |
There was a problem hiding this comment.
This is now a required field - context https://github.com/Kong/ai-deck-converter/pull/225/changes
Since gets used in deck file ai2kong command, we can't call gateway to load version and then populate this - so leaving it hardcoded.
Ideal scenario - file ai2kong and ai sync accept a new flag --min-runtime-version and override this, but I'd leave that up as an improvement
Summary
In this PR, we are bumping ai-deck-converter, and as a result of some breaking changes in it - we are making some modifications to how we consume it in decK.
These include:
Convertto handle errors and warning reportingConvertv1.20- which automatically seedsrandpackageOPTIONSin the route protocols for tests infile ai2kong