Repository navigation
fix(sandboxes): sync runtime billing API contract - #392
Merged
Merged
Conversation
shawnwu-kong
marked this pull request as ready for review
October 14, 2026 18:32
swkeever
previously approved these changes
Oct 14, 2026
swkeever
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the contract sync and handwritten transport boundaries. The snapshot matches Hosting #1891, with no public facade or package-version changes. Required CI, regeneration checks and native tests pass. No live-cloud testing was performed for this review. Land this snapshot before Hosting's automatic consumer sync.
tkkhq
reviewed
Oct 14, 2026
tkkhq
left a comment
Contributor
There was a problem hiding this comment.
The contract refresh leaves two pre-existing public-facade failures unresolved:
- An unlimited local session returns
expires_at: null, which the refreshed generated model accepts.src/volcano_sdk/sandbox_session.py:89still calls the non-null timestamp decoder, so creation fails after a successful server response. Update the public expiry type and session decoding paths; cover a null-expiry response through the facade. - Supplying
idle_timeout_secondsmakessrc/volcano_sdk/sandboxes.py:68include it in the create body. The refreshedCreateSandboxSessionRequestforbids this removed field, so the server returns HTTP 400. Align the public option and request builder with the accepted contract.
The producer contract is Hosting #1891, api/components/common/schemas.yaml:7652 and :7667. These are facade gaps, not regressions introduced by regeneration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refresh the private generated clients from the current Hosting public OpenAPI bundle and document confirmed Sandbox runtime billing. Running usage consumes account allowance and paid overage; suspended/uncertain usage and snapshots are not separately billed.
The complete contract sync also carries existing Issues, Autofix, variable-environment, and custom-domain schema changes. These remain behind the handwritten facades; no new public facade methods or package versions are introduced.
Validation: generation determinism, Ruff lint/format, mypy, basedpyright, all 2,676 unit tests, wheel build, and isolated package smoke test passed.
No package publication or live cloud acceptance was performed. Coordinated with the Sandbox MCP change in Kong/volcano-hosting.