istore_2: All 3 tiers PASS spec compliance.#575
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Conversation
Co-authored-by: LSantha <LSantha@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thecompliance analysis is complete. All three JNode compiler tiers (L1A, L1B, L2) correctly implement
istore_2per the JVM specification.Summary:
X86BytecodeVisitor.java:2931-2933,wstoreat lines 4375-4421): Correctly decodes implicit index 2, popsIntItemfrom virtual stack, computes EBP-relative offset, handles constant/register/stack/FPU cases.X86BytecodeVisitor.java:3646-3651,wstoreat lines 5368-5424): Same correct behavior with additional constant-local tracking.IRGenerator.java:387-392,GenericX86CodeGenerator.java:278-345): IR generation emitsVariableRefAssignQuad(stackOffset→index)with correct type (INT, category-1); codegen handles all addressing modes; support checker doesn't throwUnsupportedOperationException.JVM Spec (JVMS §6.5.istore_2): Opcode 0x3d, pops one
intfrom stack, stores into local variable 2. Implicit index=2. Wide prefix supported (16-bit index).Full report saved to
istore_2_compliance_report.md.Closes #324
opencode session | github run