Remove SqlserverOnlyTest marker interface from tests - #297
Merged
labkey-tchad merged 1 commit intoJul 21, 2026
Conversation
labkey-adam
approved these changes
Jul 20, 2026
bbimber
approved these changes
Jul 20, 2026
Member
Author
|
The kinship ETL is failing for some reason: |
Collaborator
|
It seems like the R packages arent installed: https://teamcity-artifacts.labkey.org/presignedTokenAuth/3f1b83bd-8860-4912-87f6-8a534a51e7de/repository/download/LabKey_263Release_Community_ExternalModulesTestPostgres/4100566:id/PMRTest.tar.gz!/PMRTest%20Project/%40files/kinship/EHR%20Kinship%20Calculation/kinship.txt_2026-07-20_14-38-41.log?__nodeId=secondary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The PMR module seems to have always supported Postgres. The test was flagged as SQL Server only, presumably because it wasn't actually deployed to any postgres servers.
The
SqlserverOnlyTestmarker interface will soon be unnecessary and should be removed from tests.Changes
SqlserverOnlyTestmarker interface from tests