LabKey SQL hints and nits - #7835
Merged
Merged
Conversation
…gres "IS DISTINCT FROM" syntax in the future.
labkey-matthewb
changed the title
labkey-matthewb
marked this pull request as ready for review
July 24, 2026 17:46
XingY
requested changes
Jul 24, 2026
| } | ||
|
|
||
| // "is distinct from" and "is not distinct from" operators in method form | ||
| labkeyMethod.put("is_distinct_from", new Method(JdbcType.BOOLEAN, 2, 2) |
Contributor
There was a problem hiding this comment.
Is this applied from a patch? They should be added around line 546 instead.
Contributor
Author
There was a problem hiding this comment.
??? must not have pushed my last commit (obviously doesn't build this way)
XingY
reviewed
Jul 24, 2026
| String notDistinctValue = token == IS ? dialect.getBooleanFALSE() : dialect.getBooleanTRUE(); | ||
| String distinctValue = token == IS ? dialect.getBooleanTRUE() : dialect.getBooleanFALSE(); | ||
|
|
||
| ret.append("(CASE WHEN (").append(a).append(") = (").append(b).append(")"); |
Contributor
There was a problem hiding this comment.
This (CASE WHEN) expression works as SELECT, but would it work in WHERE?
Contributor
Author
There was a problem hiding this comment.
Good question. I'll double check.
Contributor
Author
There was a problem hiding this comment.
A function() really should return a value, but this breaks compatibility on mssql, so I'll switch this. This is really a hack anyway, on develop I'll add support for the proper "IS DISTINCT FROM" syntax.
…wards compatible, but not very functiony)
XingY
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Targeted changes to help AI Assistant avoid and self-correct SQL generation mistakes.
Added support for CURRENT_DATE, CURRENT_TIME, CURRENT_TIMESTAMP
Related Pull Requests
Changes