Validate types when deserializing pipeline jobs and status - #7858
Merged
Conversation
labkey-jeckels
marked this pull request as ready for review
July 20, 2026 16:59
Use deprecated flag for status too
labkey-adam
approved these changes
Jul 20, 2026
| // An Object[] carries a [Ljava.lang.X; type id even for scalars that travel untyped as bare values, so | ||
| // String[]/Integer[] exercise the component-type allow that a direct String/Integer value does not. | ||
| map.put("stringArray", new String[]{"a", "b"}); | ||
| map.put("intArray", new Integer[]{1, 2}); |
Contributor
There was a problem hiding this comment.
Test a multi-dimensional array?
Contributor
Author
There was a problem hiding this comment.
Added Object[][] to the test scenario, which made me add Object[] as a supported type.
We'd still block things like Number[] or Number[][] that could be safely supported. I'll leave it here, and we can add more types as they come up in real usage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
We can improve security by restricting the types that are allowed when deserializing pipeline jobs and status messages using Jackson and XStream.
Changes
Tasks 📍