Fix jquery-dateFormat parseTime dropping the time in colon-labelled timezones

[ankurjuneja]

Rationale

DateFormat.format.date(, …) builds its time from value.toTimeString() (e.g. "00:00:00 GMT-1000 (GMT-10:00)") and parseTime splits that whole string on :. It only accepts exactly 3 parts, so any timezone whose label contains a colon — Honolulu's (GMT-10:00), India's +05:30, etc. — yields 4+ parts, fails the check, and returns an empty time that pads to 00:00. Result: every Date formatted through this library shows midnight for affected users (calendar labels, tooltips, and anywhere DateFormat.format.date is used).

Fix: strip the trailing timezone label before splitting on : (time.replace(/\s.+/, '').split(':')) — the same strip the function already does at line 82, just applied before the length check instead of after. One-token change, applied to both jquery-dateFormat.js and jquery-dateFormat.min.js (the min file is served in production per jQuery.lib.xml, compileInProductionMode="false"). Non-affected timezones and the ISO/seconds parse paths are unchanged.

Related Pull Requests

• Fix instrument scheduler datetime-local fields showing midnight on Firefox targetedms#1266

Changes

[labkey-jeckels]

Request for a quick unit test for this change:

platform/core already has a jest harness (core/jest.config.js, jsdom, testRegex '(.(test)).(ts|tsx)$'), so a regression test is cheap: load jquery-dateFormat.js and assert that a Date stub whose toTimeString() returns 08:00:00 GMT-1000 (GMT-10:00) formats to 08:00, not 00:00.

[labkey-jeckels]

Please add a note to both files to say they've been patched.