Skip to content

pg_client: fix schema name used to register rel tables - #35

Merged
adsharma merged 1 commit into
mainfrom
fix/foreign-db-name-dynamic-lookup
Jul 28, 2026
Merged

pg_client: fix schema name used to register rel tables#35
adsharma merged 1 commit into
mainfrom
fix/foreign-db-name-dynamic-lookup

Conversation

@adsharma

@adsharma adsharma commented Jul 28, 2026

Copy link
Copy Markdown
Contributor
  • Add getTableColumnNames override to AttachedPgClientDatabase that queries information_schema.columns (with FK column detection for proper ordering expected by the foreign join pushdown optimizer).
  • Store schemaName in AttachedPgClientDatabase for schema-qualified information_schema queries.
  • Set relStorage on RelGroupCatalogEntry to 'attachedDbName.tableName' so the optimizer can construct the proper SQL table reference.
  • Thread attachedDbName through PgClientCatalog constructor and use it for foreignDatabaseName (needed for DatabaseManager lookups).

@adsharma adsharma changed the title pg_client: implement getTableColumnNames and set relStorage for join … pg_client: fix schema name used to register rel tables Jul 28, 2026
…pushdown

- Add getTableColumnNames override to AttachedPgClientDatabase that
  queries information_schema.columns (with FK column detection for
  proper ordering expected by the foreign join pushdown optimizer).
- Store schemaName in AttachedPgClientDatabase for schema-qualified
  information_schema queries.
- Set relStorage on RelGroupCatalogEntry to 'attachedDbName.tableName'
  so the optimizer can construct the proper SQL table reference.
- Thread attachedDbName through PgClientCatalog constructor and use it
  for foreignDatabaseName (needed for DatabaseManager lookups).
@adsharma
adsharma force-pushed the fix/foreign-db-name-dynamic-lookup branch from 65840ae to 2893860 Compare July 28, 2026 14:36
@adsharma
adsharma merged commit 104501f into main Jul 28, 2026
2 checks passed
@adsharma
adsharma deleted the fix/foreign-db-name-dynamic-lookup branch July 28, 2026 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant