TE-29179: vendor dom-serializer with canvas + iframe capture for Salesforce/Aura pages; bump to 4.1.84 - #568
Open
shrinishLT wants to merge 2 commits into
Open
shrinishLT wants to merge 2 commits into
shrinishLT wants to merge 2 commits into
Conversation
parthlambdatest
approved these changes
Sep 18, 2026
shrinishLT
force-pushed
the
TE-29179
branch
from
September 18, 2026 14:53
08bd88e to
9929e41
Compare
shrinishLT
changed the title
…ura/Salesforce path Rebuilt from smartui-cli-dom-serializer PR LambdaTest#17. Salesforce dashboard and report <canvas> charts, including those inside same-origin iframes, are now captured; the Aura path is otherwise unchanged. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RDVDDncWZxnu1eh3Mp8Dj8
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RDVDDncWZxnu1eh3Mp8Dj8
shrinishLT
force-pushed
the
TE-29179
branch
from
September 18, 2026 15:35
9929e41 to
6ff9e8a
Compare
shrinishLT
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On Salesforce Lightning pages the served
dom-serializer.jstakes an Aura-specific branch (DOT-4375) that returns a rawcloneNode(true). A<canvas>has no pixels in HTML and dashboards/reports render inside same-origin iframes the branch never entered, so charts arrived empty / frames blank (customer org 123300, build03dcf0af…, snapshotCOMPLIANCE_243654ComponentLayout).Change
src/dom/dom-serializer.js: rebuilt from smartui-cli-dom-serializer#17 — the Aura branch now inlines drawn canvases as<img>(data URL) and embeds same-origin iframes assrcdoc, serialized the same way. Byte-identical to that PR'sdist/bundle.js.package.json: 4.1.83 → 4.1.84.The Aura branch is deliberately kept: routing Salesforce pages through the standard pipeline converts LWC synthetic shadow roots into real ones and cuts them off from document CSS (verified live: SLDS icons render at intrinsic size).
Validation — stage, live lambdatest.lightning.force.com, playwright SDK (project
01M2T8WTXKC9P4FF6MN804YCV7)022c382f…)39028bef…)Ticket: https://lambdatest.atlassian.net/browse/TE-29179
Depends on: LambdatestIncPrivate/smartui-cli-dom-serializer#17
🤖 Generated with Claude Code
https://claude.ai/code/session_01RDVDDncWZxnu1eh3Mp8Dj8