LT-53534: support Rails 8 and Devise 5 from v2.2.0 - #2
Merged
relsett merged 3 commits intoAug 25, 2026
Merged
Conversation
Rails 7 removes Active Record's deprecated update_attributes method. Direct OTP issuance and cleanup would therefore fail before an authentication flow could complete. Switch these calls to update and rename the non-persisted GuestUser test double's matching method so the test harness continues to mirror the production interface.
With the newer ROTP versions required by the Rails 8 matrix, verification returns a Unix timestamp while the persisted column expects a datetime. Convert it explicitly to UTC Time before assignment. Rails 8 also validates the resource action list strictly: resend_code is declared as a separate collection route and must not be listed as a resource action. Keep that endpoint while limiting the resource actions to show and update.
relsett
force-pushed
the
feature/LT-53534-v2.2.0-rails-8-compatibility
branch
from
August 24, 2026 17:25
2412113 to
6fac7ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
База
Ветка построена от точного upstream tag
v2.2.0, который использует leveltravel. Post-release измененияupstream/masterне входят.Runtime
Из upstream PR #219 взяты только три совместимые правки с сохранением авторства:
update_attributesзаменён наupdate;Time;resend_codeостаётся collection route и исключён из списка resource actions.Runtime diff затрагивает два файла гема.
Test-only
resend_coderoute;Dummy-app больше не поднимает неиспользуемый asset pipeline. В PR нет workflow, manifest, новых ассетов, monkey patch, удаления Travis или legacy dependency matrix.
Проверка
Локально на Ruby
3.4.10и ROTP6.2.0:8.0.5.1× Devise4.9.4/5.0.4— 81 example, 0 failures;8.1.3.1× Devise4.9.4/5.0.4— 81 example, 0 failures;После merge leveltravel PR #26241 будет закреплён на exact SHA этого PR; application monkey patch там удалён.