fix: keep the wordpress hash when it already matches the new password - #23
Merged
Merged
Conversation
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
YvesCesar
marked this pull request as draft
October 1, 2026 22:10
Signed-off-by: YvesCesar <yvesamorim73@gmail.com>
YvesCesar
marked this pull request as ready for review
October 1, 2026 22:17
vitormattos
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22
BeforePasswordUpdatedListenernow reads the current WordPress hash with theget_wordpress_userquery and only writes a new one when that hash does not match the new password. Since that query also matches by email, the hash is taken from the row whoseuidis the user, the same row theset_wordpress_passwordquery updates. A password change that started in WordPress reaches Nextcloud with a password WordPress already stores, so the hash, and the auth cookie tied to it, stay untouched. A password changed in Nextcloud is still written to WordPress.Tests (
tests/Unit/Listener/BeforePasswordUpdatedListenerTest.php, against a SQLite database):tests/bootstrap.phpgains stubs forIUser,Event,IEventListenerandBeforePasswordUpdatedEvent, like the existingIConfigone.