Skip to content

refactor: shared shell types, schema ownership, workspace UI reuse - #1021

Merged
tiankaima-copilot merged 2 commits into
mainfrom
refactor/workspace-architecture-unify
Sep 6, 2026
Merged

refactor: shared shell types, schema ownership, workspace UI reuse#1021
tiankaima-copilot merged 2 commits into
mainfrom
refactor/workspace-architecture-unify

Conversation

@tiankaima-copilot

Copy link
Copy Markdown
Collaborator

Summary

  • Extract AppPageLoadEvent + page copy into src/lib/shell/ so weather/young no longer depend on features/workspace for load types.
  • Invert publications read request schemas and catalog metadata response schemas into feature lib/ with thin OpenAPI re-exports.
  • Share WorkspaceTaskToolbar / WorkspaceEmptyState across homework/todo/exam (and simple empty) UIs.
  • Shrink E2E probeOnlyRoutes; remove the dead empty integration probeOnly branch.

Test plan

  • bunx svelte-check / tsc
  • bunx vitest run (2588 passed)
  • CI full check

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 4, 2026

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
life-ustc e90166c Sep 06 2026, 07:13 AM

@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from 007ffae to be1457c Compare September 6, 2026 05:25
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from 49bdf35 to eb2d360 Compare September 6, 2026 05:27
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from be1457c to 7922984 Compare September 6, 2026 05:29
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from eb2d360 to fea9510 Compare September 6, 2026 05:30
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from 7922984 to 8407855 Compare September 6, 2026 05:31
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from fea9510 to ce27762 Compare September 6, 2026 05:31
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from 8407855 to 4aaf6be Compare September 6, 2026 05:51
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from ce27762 to 8c20134 Compare September 6, 2026 05:52
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from 4aaf6be to 3be0dd1 Compare September 6, 2026 05:54
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from 8c20134 to cf75740 Compare September 6, 2026 05:55
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from 3be0dd1 to 28ec074 Compare September 6, 2026 05:59
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from cf75740 to dc4d174 Compare September 6, 2026 05:59
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from 28ec074 to a258dd4 Compare September 6, 2026 06:03
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from dc4d174 to ef63301 Compare September 6, 2026 06:03
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from a258dd4 to 500c7e4 Compare September 6, 2026 06:11
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from ef63301 to 942de05 Compare September 6, 2026 06:12
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from 500c7e4 to 17e46f3 Compare September 6, 2026 06:30
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from 942de05 to b6469cd Compare September 6, 2026 06:30
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from 17e46f3 to d3fbdc4 Compare September 6, 2026 06:33
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from b6469cd to 90b118f Compare September 6, 2026 06:33
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-hotspot-splits branch from d3fbdc4 to 099d076 Compare September 6, 2026 06:54
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from 90b118f to cd9b483 Compare September 6, 2026 06:54
Base automatically changed from refactor/workspace-hotspot-splits to main September 6, 2026 07:11
Extract AppPageLoadEvent/page copy into lib/shell so weather/young stop importing workspace; invert publications read + catalog metadata schemas into feature lib; add shared WorkspaceTaskToolbar/EmptyState; shrink e2e probeOnly and drop the empty integration probeOnly branch.
Biome import/format failures blocked Check; CatalogLinkClick sorts before CommentReaction so the ownership assertion must match DB order.
@tiankaima-copilot
tiankaima-copilot force-pushed the refactor/workspace-architecture-unify branch from cd9b483 to e90166c Compare September 6, 2026 07:11
@tiankaima-copilot
tiankaima-copilot merged commit 7b41d48 into main Sep 6, 2026
18 checks passed
@tiankaima-copilot
tiankaima-copilot deleted the refactor/workspace-architecture-unify branch September 6, 2026 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants