host/limine: Reject excess bios-install positional arguments - #660
Open
pro-utkarshM wants to merge 1 commit into
Open
pro-utkarshM wants to merge 1 commit into
pro-utkarshM wants to merge 1 commit into
Conversation
Assisted-by: Codex:gpt-6-astra Signed-off-by: Utkarsh Maurya <projects.utkarshMaurya@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bios-install disk.img 1 2silently replaces the first partition index with the second and can install into the wrong GPT partition. Reject a second index operand before device initialization, using the existing cleanup path to close the opened device.Validation: all 14 MBR/GPT regression cases pass. Nine malformed invocations, including interspersed options and quiet mode, now fail without changing the image; five valid controls preserve autodetection and explicit partition selection. The standalone regression is in the linked issue. The C99 host build and full LLVM build (
./bootstrap,./configure --enable-werror --enable-all,make all) passed with warnings treated as errors.Fixes #659.