feat: add CPU staging buffer to access GPU memory via unified buffer - #37
Open
WillowWang0216 wants to merge 3 commits into
Open
feat: add CPU staging buffer to access GPU memory via unified buffer#37WillowWang0216 wants to merge 3 commits into
WillowWang0216 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When integrating vllm with mooncake, GPU memory addresses need to be passed to mooncake for data transfer. However, the existing ubtransport implementation does not support registering GPU memory directly, making it impossible to fetch data from the GPU side.
To address this, a CPU staging buffer mechanism is introduced:
Add a CPU staging area as an intermediate buffer between GPU memory and ubtransport
Before data transfer, copy data from GPU memory to the CPU staging buffer (D2H)
mooncake reads data from the CPU staging buffer via ubtransport
For reverse transfers, data is first written to the CPU staging buffer, then copied back to GPU memory (H2D)
This approach enables indirect access and transfer of GPU memory data without modifying the ubtransport registration logic.