Skip to content

Rename the common transport handshake protocol - #90

Closed
Spicy-cream wants to merge 1 commit into
LinQuickDev:transport-handshakefrom
Spicy-cream:review/pr3535-transport-protocol-name
Closed

Spicy-cream wants to merge 1 commit into
LinQuickDev:transport-handshakefrom
Spicy-cream:review/pr3535-transport-protocol-name

Conversation

@Spicy-cream

Copy link
Copy Markdown

Summary

Address chenBright's naming review on apache#3535:

  • Rename PROTOCOL_RDMA_HANDSHAKE to PROTOCOL_TRANSPORT_HANDSHAKE, keeping value 1.
  • Register the common parser as transport_handshake and update the server's always-enabled protocol check.
  • Update whitelist coverage and add registration, enum-value, and callback checks.
  • Remove the comment retaining the RDMA-specific name.

RDMA-specific wire formats and files, CI workflows, and URMA documentation are unchanged.

Review: apache#3535 (comment)

Validation

  • Release static library build passed.
  • Common handshake: 28 tests passed.
  • Server protocol whitelist: 4 tests passed.
  • RDMA: 92 tests passed.
  • New protocol-registration test: 100 repetitions passed.
  • UBSHM: 43 tests passed on both debugger and normal reruns. The initial suite run segfaulted during shared-memory cleanup; its cause is not established. No UBSHM lifecycle code is changed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant