docs(build): fix English HTML stylesheet path one level too shallow#4174
Merged
Conversation
English renders from build/adoc/en with a stem that omits the en/ prefix, so the cssrel rule emits ../ instead of ../../ and the pages load a nonexistent en/asciidoctor.css and render unstyled. Add an en-specific rule with the +1. Translated languages and man pages were already correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
English doc pages were rendering unstyled: they linked
en/asciidoctor.css(which does not exist) instead of the stylesheet at the html root.Cause: since c774b79 English renders from
build/adoc/enwith a build-rule stem that omits theen/prefix, so the$(DOC_OUT_ADOC)/%.htmlcssrel rule counts one directory too few and emits../instead of../../. Translated languages were unaffected (their stem includes the lang dir), and man pages use their own rule.Fix: add an
$(DOC_OUT_ADOC)/en/%.htmlcssrel rule with the+1, matching the$(DOC_SRCDIR)path that carried it before.Verified on a clean full build (all 8 languages): every English page's stylesheet depth now matches its directory depth (1174 en+de pages checked, 0 mismatches), man pages and index pages unchanged, checkref clean, and a second build is a no-op with a clean repo.