build: Don't use 0 as NULL/nullptr in pointer compare and assignment#4179
Open
BsAtHome wants to merge 1 commit into
Open
build: Don't use 0 as NULL/nullptr in pointer compare and assignment#4179BsAtHome wants to merge 1 commit into
BsAtHome wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are many places in the sources where the value
0is used to meanNULLornullptr. The ultimate value of these may all be zero, but they are of very different types (pointer vs. integer). This leads to confusion in comparison and wrong assignments where one forgets to dereference or an instance in classicladder assigningFALSEto a pointer.This PR fixes all (detected) instances that gcc and clang could find using the
-Wzero-as-null-pointer-constantoption and is selectable at configure time. There are a few instances in the C/C++ to Python interface code where this option is explicitly ignored with a pragma because the system's headers use the same confusion and cannot be easily fixed.