Skip to content

fix(worker): dedupe MCP SDK + fix agent.ts type errors, add CI tsc gate #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
liplus-lin-lay merged 1 commit into from
Jun 25, 2026
Merged

fix(worker): dedupe MCP SDK + fix agent.ts type errors, add CI tsc gate #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ jobs:
- name: mcp-server client migration tests
run: node --test test/*.test.mjs
working-directory: mcp-server
- name: worker install + dry-run deploy + OAuth device-flow tests
- name: worker install + typecheck + dry-run deploy + OAuth device-flow tests
run: |
npm ci
npm run typecheck
npx wrangler deploy --dry-run --outdir dist
npm test
working-directory: worker
Expand Down
48 changes: 4 additions & 44 deletions worker/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions worker/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@
"scripts": {
"dev": "wrangler dev",
"deploy": "wrangler deploy",
"typecheck": "tsc --noEmit",
"test": "tsx --test test/*.test.ts && vitest run --config vitest.workers.config.ts"
},
"dependencies": {
"@modelcontextprotocol/sdk": "^1.0.0",
"@modelcontextprotocol/sdk": "1.26.0",
"agents": "^0.8.0",
"zod": "^4.0.0"
},
Expand All @@ -22,9 +23,10 @@
"wrangler": "^4.0.0"
},
"comments": {
"overrides": "Pin @cloudflare/workers-types across the tree to the version the worker code is written against; the vitest-pool-workers toolchain otherwise pulls a newer one whose stricter binding types can break existing src types (types-only; runtime unaffected)."
"overrides": "Pin @cloudflare/workers-types across the tree to the version the worker code is written against; the vitest-pool-workers toolchain otherwise pulls a newer one whose stricter binding types can break existing src types (types-only; runtime unaffected). Pin @modelcontextprotocol/sdk to 1.26.0 so the tree holds a single copy: agents@0.8.2 nests its own 1.26.0, and a separate worker-direct copy made McpServer's private _serverInfo incompatible at the type level (types-only; 1.26/1.27 are runtime-compatible)."
},
"overrides": {
"@cloudflare/workers-types": "$@cloudflare/workers-types"
"@cloudflare/workers-types": "$@cloudflare/workers-types",
"@modelcontextprotocol/sdk": "$@modelcontextprotocol/sdk"
}
}
4 changes: 2 additions & 2 deletions worker/src/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ interface Env {
}

/** Tenant context passed via props when creating per-tenant instances */
export interface TenantProps {
export type TenantProps = {
account_id?: number;
account_login?: string;
/** All account IDs (user + orgs) whose stores this session can read */
accessible_account_ids?: number[];
}
};

export class WebhookMcpAgent extends McpAgent<Env, unknown, TenantProps> {
server = new McpServer({
Expand Down
Loading