refactor: smart pointers and fix ownership - #167
Merged
Codecov / codecov/project
succeeded
Jul 28, 2026 in 0s
61.50% (+1.68%) compared to 87d324c
View this Pull Request on Codecov
61.50% (+1.68%) compared to 87d324c
Details
Codecov Report
❌ Patch coverage is 71.42857% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.50%. Comparing base (87d324c) to head (1773925).
✅ All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| src/tray_qt.cpp | 61.11% | 2 Missing and 12 partials |
| src/QtTrayMenu.cpp | 88.23% | 1 Missing and 1 partial |
Additional details and impacted files
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 59.81% 61.50% +1.68%
==========================================
Files 5 5
Lines 443 439 -4
Branches 162 159 -3
==========================================
+ Hits 265 270 +5
+ Misses 121 110 -11
- Partials 57 59 +2 | Files with missing lines | Coverage Δ | |
|---|---|---|
| src/QtTrayMenu.h | 100.00% <100.00%> (ø) |
|
| src/QtTrayMenu.cpp | 68.88% <88.23%> (+2.78%) |
⬆️ |
| src/tray_qt.cpp | 64.75% <61.11%> (+0.96%) |
⬆️ |
Continue to review full report in Codecov by Harness.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update 87d324c...1773925. Read the comment docs.
Loading