Repository navigation
Fail integration tests on logged warnings - #2
Open
timcassell wants to merge 1 commit into
Open
timcassell wants to merge 1 commit into
timcassell wants to merge 1 commit into
Conversation
A failed reference-gathering pass is only a warning, and the benchmark still builds and runs, so CanExecute's full validation now fails on any logged warning. Analyser conclusions are excluded since they depend on the machine. Tests that expect warnings opt out with allowWarnings, as the NativeAOT tests do for BenchmarkDotNet's own trim and AOT warnings. With publishing toolchains going through reference gathering, that check catches a Wasm failure: the static web assets pipeline converts the program's assembly, which the gathering pass never compiles. The pass only resolves references, so it disables static web assets. The other integration tests now cover gathering for publishing toolchains, which makes the dedicated R2R gathering test redundant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on dotnet#3312's switch to full integration builds for publishing toolchains.
CanExecute's full validation now fails on any logged warning, excluding the analyser conclusions (machine-dependent). Tests that expect warnings opt out withallowWarnings. The NativeAOT tests do, for BenchmarkDotNet's own IL2104/IL3053 trim and AOT warnings.StaticWebAssetsEnabled=false.🤖 Generated with Claude Code