Repository navigation
Do not shadow/re-inject fields in child-classes #2573
Description
How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Linux
What is the issue affecting?
Diagnostics/Syntax Checking
Expected Behaviour
When assigning to a field which is already defined in one of it's supers, no injection should be used.
Actual Behaviour
Assigning to existing field is not possible as I effectively end up with two fields A.test and B.test.
The only valid workaround I know would be using setters in A.
Just disabling (exact) does not solve the issue, just disable the warning.
Reproduction steps
---@class (exact) A
---@field test number
local a = {}
function a:init()
--This is fine
self.test = 0
end
---@class (exact) B : A
local b = {}
function b:init()
--This is an injection and thus invalid
self.test = 0
endAdditional Notes
If shadowing a field is explicitly wanted, one can still define/type explicitly. But I think by default, no additional field should get injected.
Issue is a bit related to @override (#2569).
Log File
No response
Activity
Luke100000 commentedon Mar 19, 2024
I added a fix for this, but because I have honestly no idea what I'm doing its probably not a proper solution. It works for me tho: Luke100000@ad80ae9
It effectively disables looking for local field definitions for exact classes. They are invalid anyways afaik.
alex-courtis commentedon Sep 8, 2024
Confirmed fix on 3.10.5.
Inherited fields and types are correctly identified.
Appreciate your work @Luke100000 - I'd me most grateful if you raised a pull request for the fix.
scfmod commentedon Apr 5, 2026
Bumping this issue as it will work when your class object is defined as a local variable, but if it's defined as a global variable it will still give a warning
scfmod commentedon Apr 5, 2026
Also, it seems to break code completion lookup