test(push): classify failing command substitution as legacy control - #54
Merged
Merged
Conversation
Owner
Author
|
Self-review completed against main dc58996. HEAD 45d83f6 changes only test mode classification/comments (+6/-5); no controller, assertions or production implementation change. Readback diff, whitespace and bash -n passed. CI 34252693792 passed Ubuntu and Debian: full=false, parser only, plain/pipeline six delays each, every exit 129 with handler marker required. Legacy command/process/snapshot code is retained, not rerun to green. No full-suite claim. Ready for user merge decision; main failure evidence remains retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Main run 34251584749, Debian Bash 5.2.37, reproduced trap unexpected EOF and exit 2 in command mode, round 1, delay 0. That control uses value=$(printf x); it is another command-substitution reproducer, not the pipeline replacement. The failure occurs before pipeline and batch tests.
Scope
Only tests/test-hup-parser.sh. Move command into the existing HUP_PARSER_INCLUDE_LEGACY opt-in group alongside process and snapshot. Retain its code and original red evidence. Default plain/pipeline modes retain all six delays, handler marker, exact exit 129, no-match status assertion, and hard per-case timeout. No production code, signal handler, lifecycle barrier or test runner changes.
Validation
Local bash -n and whitespace inspection passed; behavior tests run only in CI. Existing selector will run the changed parser suite in both environments. Full main and lint validations are tracked separately; a selective pass is not a full-suite claim.
Risks
This explicitly removes a newly demonstrated broken substitution control from the default passing gate, not a Bash fix. Legacy mode remains expected to expose failures and stops at the first failure. Does not establish a causal fix for deferred batch issue #53. Pipeline coverage is finite; no guaranteed immunity claim.
Rollback
Revert the eventual squash commit through a PR to restore default command coverage. No deployment or data migration. Merge requires explicit confirmation.